Apply patch https://sourceforge.net/p/crossfire/patches/374/ courtesy Rebecca Kelly.

git-svn-id: svn+ssh://svn.code.sf.net/p/crossfire/code/arch/trunk@21395 282e977c-c81d-0410-88c4-b93c2d0d6712

ChangeLog

@@ -1,3 +1,16 @@
+Remove Use Magic Item from Barbarian and replace it with Punching
+Barbarians lacking Punching is likely an oversight stemming from the fact that
+they don't get the basic_skills package. Lacking UMI means that they won't be
+able to use wands, horns, powders, and most other limited-use magic items;
+potions and magic equipment are still usable, though.
+This also splits the player skill packages into their own trs file and gives
+them a bit of additional documentation.
+player/class/Warrior/barbarian.arc
+player/class/Warrior/barbarian.trs
+player/player_skills.trs
+treasures.trs
+Rebecca Kelly 2020-09-10
+
 Fix Alchemist spell school and Alchemy spell description
 The Alchemist was assigned the Sorcery school (and given Sorcery and Evocation
 spellbooks) despite the fact that Alchemy is a Summoning spell. This may have

player/class/Warrior/barbarian.trs

@@ -1,3 +1,7 @@
+# Class items for the Barbarian. Note that all skills from the "basic package"
+# (except Literacy and Use Magic Item) are replicated here, in order to let
+# Barbarians start without them. Don't forget to update this file as needed if
+# you change player_skills.trs!
 treasure barbarian_class_items
   arch skill_one_handed_weapon
   more
@@ -11,7 +15,7 @@ treasure barbarian_class_items
   more
   arch skill_remove_trap
   more
-  arch skill_use_magic_item
+  arch skill_punching
   more
   arch guide_melee
   more

treasures.trs

@@ -38,7 +38,7 @@ end
 #
 ##############################################################
 #
-# BODY PARTS - 
+# BODY PARTS -
 #
 # human/man-sized body parts
 treasureone human_parts
@@ -88,7 +88,7 @@ treasure door
 end
 #
 # skill scrolls
-# better scrolls are harder to find 
+# better scrolls are harder to find
 # ordered by skill names
 treasureone random_knowledge
   arch scroll_alchemy
@@ -117,8 +117,8 @@ treasureone random_knowledge
   arch scroll_hiding
     chance 9
   more
-#   the inscription skill is only available as a pen  
-  arch stylus	
+#   the inscription skill is only available as a pen
+  arch stylus
     chance 10
   more
   arch scroll_jewelry
@@ -1274,7 +1274,7 @@ treasureone uncommon_weapons
     magic 3
     chance 5
   end
-# uncommon artifacts 
+# uncommon artifacts
 treasureone uncommon_artifacts
   arch potion_shielding
     chance 5
@@ -1777,8 +1777,8 @@ treasure poor
     chance 20
   end
 # I switched the names to '_old' -- these lists
-# are just the way standard/rich were before we 
-# started adding bodyparts to the treasure mix. 
+# are just the way standard/rich were before we
+# started adding bodyparts to the treasure mix.
 # -b.t.
 treasure standard_old
   arch bow
@@ -2008,54 +2008,12 @@ treasure throw_rich
   more
   list rich
   end
-##############################################################################
-# start of starting equipment for players.
-#
-# All players will start with these skills
-# -- only skills critical to being able to
-# play should go here. -b.t.
-treasure basic_skills
-  arch skill_throwing
-  more
-  arch skill_find_traps
-  more
-  arch skill_remove_trap
-  more
-  arch skill_use_magic_item
-  more
-  arch skill_literacy
-  more
-  arch skill_punching
-  end
-# basic set for fighter players
-treasure fighter_skills
-  arch skill_one_handed_weapon
-  more
-  arch skill_two_handed_weapon
-  more
-  arch skill_missile_weapon
-  more
-  list basic_skills
-  end
-# basic set for talisman spellcasting players
 treasure mage_skills
   arch talisman_sorcery
   end
-# basic set for multi-spellcasting players
-# Note that removed the spell skill form here,
-# since many things should start with this package,
-# but spell might be different.
-treasure wizard_skills
-  arch skill_one_handed_weapon
-  more
-  arch skill_praying
-  more
-  list basic_skills
-  end
 treasure prayer_skills
   arch skill_praying
   end
-#
 treasure monk
   list basic_skills
   more
@@ -2108,7 +2066,7 @@ treasure human
 treasure ninja
   list fighter_skills
   more
-  arch skill_jumping 
+  arch skill_jumping
   more
   arch skill_hide
   more